Skip to content

Commit

Permalink
fix(create-cloudflare): rename category (#6557)
Browse files Browse the repository at this point in the history
  • Loading branch information
edmundhung authored Aug 22, 2024
1 parent a9f36ef commit 2e9aa53
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 6 deletions.
5 changes: 5 additions & 0 deletions .changeset/three-months-work.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"create-cloudflare": patch
---

fix: renamed the "Demo Application" category to "Application Starter"
8 changes: 4 additions & 4 deletions packages/create-cloudflare/e2e-tests/cli.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ describe.skipIf(frameworkToTest || isQuarantineMode())(
matcher: /What would you like to start with\?/,
input: {
type: "select",
target: "Demo application",
target: "Application Starter",
assertDescriptionText:
"Select from a range of starter applications using various Cloudflare products",
},
Expand All @@ -255,7 +255,7 @@ describe.skipIf(frameworkToTest || isQuarantineMode())(
);

expect(projectPath).toExist();
expect(output).toContain(`category Demo application`);
expect(output).toContain(`category Application Starter`);
expect(output).toContain(`type API starter (OpenAPI compliant)`);
},
);
Expand All @@ -270,7 +270,7 @@ describe.skipIf(frameworkToTest || isQuarantineMode())(
matcher: /What would you like to start with\?/,
input: {
type: "select",
target: "Demo application",
target: "Application Starter",
},
},
{
Expand Down Expand Up @@ -300,7 +300,7 @@ describe.skipIf(frameworkToTest || isQuarantineMode())(
input: {
type: "select",
target: "Framework Starter",
assertDefaultSelection: "Demo application",
assertDefaultSelection: "Application Starter",
},
},
{
Expand Down
2 changes: 1 addition & 1 deletion packages/create-cloudflare/src/helpers/args.ts
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ const cliDefinition: ArgumentsDefinition = {
values: [
{ name: "hello-world", description: "Hello World example" },
{ name: "web-framework", description: "Framework Starter" },
{ name: "demo", description: "Demo application" },
{ name: "demo", description: "Application Starter" },
{ name: "remote-template", description: "Template from a Github repo" },
],
},
Expand Down
2 changes: 1 addition & 1 deletion packages/create-cloudflare/src/templates.ts
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,7 @@ export const createContext = async (
description: "Select from the most popular full-stack web frameworks",
},
{
label: "Demo application",
label: "Application Starter",
value: "demo",
description:
"Select from a range of starter applications using various Cloudflare products",
Expand Down

0 comments on commit 2e9aa53

Please sign in to comment.