Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Miniflare 3] Switch Miniflare's CI back to Node 20 #685

Merged
merged 1 commit into from
Oct 5, 2023
Merged

[Miniflare 3] Switch Miniflare's CI back to Node 20 #685

merged 1 commit into from
Oct 5, 2023

Conversation

mrbbot
Copy link
Contributor

@mrbbot mrbbot commented Sep 9, 2023

Hey! 👋 We switched to Node 18 as part of #623, to get around cloudflare/workers-sdk#3626. Now that Miniflare's simulators are implemented as Durable Objects, we no longer hit the erroneous Node code paths, so can switch back to version 20.

@mrbbot
Switch Miniflare's CI back to Node 20
0070746 
We switched to Node 18 as part of #623, to get around
cloudflare/workers-sdk#3626. Now that Miniflare's simulators are
implemented as Durable Objects, we no longer hit the erroneous
Node code paths, so can switch back to version 20.
@changeset-bot
Copy link

changeset-bot bot commented Sep 9, 2023

⚠️ No Changeset found

Latest commit: 0070746

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mrbbot mrbbot requested a review from a team September 9, 2023 11:46
@mrbbot mrbbot marked this pull request as ready for review September 9, 2023 11:46
rozenmd
rozenmd reviewed Sep 11, 2023
View reviewed changes
.github/workflows/test.yml
@@ -19,7 +19,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
node: [16.13.0, 18]
node: [16.13.0, 20]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With Node 16 going EOL today, do we still want to build for it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would think changing our minimum supported Node version would require a major version bump. We'd also probably want to bump Wrangler's minimum support version too.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, could we bump this to 16.14 to be inline with Wrangler?

@mrbbot mrbbot merged commit e63211f into tre Oct 5, 2023
8 checks passed
@mrbbot mrbbot deleted the bcoll/tre-node-20-ci branch October 5, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rozenmd rozenmd rozenmd left review comments

@penalosa penalosa penalosa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrbbot @rozenmd @penalosa