Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Miniflare 3] Switch Miniflare's CI back to Node 20 #685

Merged
merged 1 commit into from
Oct 5, 2023
Merged

[Miniflare 3] Switch Miniflare's CI back to Node 20 #685

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
node: [16.13.0, 18]
node: [16.13.0, 20]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With Node 16 going EOL today, do we still want to build for it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would think changing our minimum supported Node version would require a major version bump. We'd also probably want to bump Wrangler's minimum support version too.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, could we bump this to 16.14 to be inline with Wrangler?

# See supported Node.js release schedule at https://nodejs.org/en/about/releases/

steps:
Expand Down