Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 BUG: bucket.put() doesn't resolve in wrangler local mode on node@20 #3626

Closed
Rei-x opened this issue Jul 17, 2023 · 1 comment
Closed
Labels
bug Something that isn't working

Comments

@Rei-x
Copy link

Rei-x commented Jul 17, 2023

Which Cloudflare product(s) does this pertain to?

R2

What version(s) of the tool(s) are you using?

3.2.0 [Wrangler]

What version of Node are you using?

20

What operating system are you using?

Linux

Describe the Bug

await bucket.put("mario", "luigi");

Never actually resolves and also doesn't throw any errors, but I can see it writes to file.
Methods like bucket.list() work fine,

It occurs only in local mode on node@20 (node@18 and deployed version works fine).

Please provide a link to a minimal reproduction

https://github.com/Rei-x/r2-bug-repro

Please provide any relevant error logs

No response

@Rei-x Rei-x added the bug Something that isn't working label Jul 17, 2023
@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Jul 17, 2023
@mrbbot
Copy link
Contributor

mrbbot commented Jul 24, 2023

Hey! 👋 Thanks for raising this. I think this may be caused by nodejs/node#48668, which was introduced in Node 20.4.0. It looks like Node 20.3.0 doesn't reproduce this issue, so I'd stick with that for the time being. I'll close this issue, since there's not much we can do until Node fixes this.

@mrbbot mrbbot closed this as completed Jul 24, 2023
@github-project-automation github-project-automation bot moved this from Untriaged to Done in workers-sdk Jul 24, 2023
mrbbot added a commit to cloudflare/miniflare that referenced this issue Aug 14, 2023
mrbbot added a commit to cloudflare/miniflare that referenced this issue Aug 17, 2023
mrbbot added a commit to cloudflare/miniflare that referenced this issue Aug 17, 2023
mrbbot added a commit to cloudflare/miniflare that referenced this issue Aug 17, 2023
mrbbot added a commit to cloudflare/miniflare that referenced this issue Aug 17, 2023
mrbbot added a commit to cloudflare/miniflare that referenced this issue Aug 17, 2023
mrbbot added a commit to cloudflare/miniflare that referenced this issue Aug 17, 2023
mrbbot added a commit to cloudflare/miniflare that referenced this issue Sep 5, 2023
mrbbot added a commit to cloudflare/miniflare that referenced this issue Sep 5, 2023
mrbbot added a commit to cloudflare/miniflare that referenced this issue Sep 9, 2023
We switched to Node 18 as part of #623, to get around
cloudflare/workers-sdk#3626. Now that Miniflare's simulators are
implemented as Durable Objects, we no longer hit the erroneous
Node code paths, so can switch back to version 20.
mrbbot added a commit to cloudflare/miniflare that referenced this issue Oct 5, 2023
We switched to Node 18 as part of #623, to get around
cloudflare/workers-sdk#3626. Now that Miniflare's simulators are
implemented as Durable Objects, we no longer hit the erroneous
Node code paths, so can switch back to version 20.
mrbbot added a commit that referenced this issue Oct 31, 2023
mrbbot added a commit that referenced this issue Nov 1, 2023
mrbbot added a commit that referenced this issue Nov 1, 2023
mrbbot added a commit that referenced this issue Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that isn't working
Projects
None yet
Development

No branches or pull requests

3 participants