fix: upgrade csv-parse to 5.3.3 and update option names #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pty_values (field was renamed in csv-parse 5.0.0)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #299
This upgrades
csv-parseto the latest 5.3.3 in theplugin-configpackage. I also had to update both uses of this package in theplugin-configandcompilepackages to use the new name for one option that was renamed in 5.x (useskip_records_with_empty_valuesinstead ofskip_lines_with_empty_values).Tests are all passing; I will merge this right away so that I can publish new versions of these and other packages.
/cc @ToddFincannonEI