Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade csv-parse to 5.3.3 and update option names #300

Merged
merged 2 commits into from
Dec 10, 2022
Merged

fix: upgrade csv-parse to 5.3.3 and update option names #300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73fa81d
build: upgrade csv-parse to 5.3.3 in plugin-config package
chrispcampbell Dec 10, 2022
471dccf
fix: use skip_records_with_empty_values instead of skip_lines_with_em…
chrispcampbell Dec 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/compile/src/_shared/helpers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ export let readCsv = (pathname, delimiter = ',') => {
columns: false,
trim: true,
skip_empty_lines: true,
skip_lines_with_empty_values: true
skip_records_with_empty_values: true
}
try {
let data = B.read(pathname)
Expand Down
2 changes: 1 addition & 1 deletion packages/plugin-config/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
},
"dependencies": {
"byline": "^5.0.0",
"csv-parse": "^4.15.4",
"csv-parse": "^5.3.3",
"sanitize-html": "^2.7.1"
},
"peerDependencies": {
Expand Down
4 changes: 2 additions & 2 deletions packages/plugin-config/src/context.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import { readFileSync } from 'fs'
import { join as joinPath, relative } from 'path'

import parseCsv from 'csv-parse/lib/sync.js'
import { parse as parseCsv } from 'csv-parse/sync'

import type { BuildContext, InputSpec, LogLevel, OutputSpec } from '@sdeverywhere/build'

Expand Down Expand Up @@ -174,7 +174,7 @@ function readCsvFile(path: string): CsvRow[] {
columns: true,
trim: true,
skip_empty_lines: true,
skip_lines_with_empty_values: true
skip_records_with_empty_values: true
})
}

Expand Down
8 changes: 2 additions & 6 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.