Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update csv-parse in plugin-config package and update option names in compile package #299

Closed
chrispcampbell opened this issue Dec 10, 2022 · 2 comments · Fixed by #300 or #294
Closed
Assignees
Labels
dependencies Pull requests that update a dependency file improvement pkg:compile pkg:plugin-config

Comments

@chrispcampbell
Copy link
Contributor

The csv-parse dependency was updated in the compile package yesterday, but the one in the plugin-config package wasn't updated. We should update that one too so that we don't impose two versions on users.

@chrispcampbell chrispcampbell added dependencies Pull requests that update a dependency file improvement pkg:plugin-config labels Dec 10, 2022
@chrispcampbell chrispcampbell self-assigned this Dec 10, 2022
@ToddFincannonEI
Copy link
Collaborator

Good catch! Note this update requires a change in the import.

import { parse as parseCsv } from 'csv-parse/sync'

@chrispcampbell
Copy link
Contributor Author

@ToddFincannonEI: I just found (thanks to a TypeScript compilation error) that the skip_lines_with_empty_values was changed some time ago (for csv-parse 5.0.0) to be skip_records_with_empty_values:
https://www.adaltas.com/en/2021/11/15/csv-version-6/

So I will update both the uses of that option in both the compile package and the plugin-config package as part of the forthcoming PR.

@chrispcampbell chrispcampbell changed the title Update csv-parse in plugin-config package Update csv-parse in plugin-config package and update option names in compile package Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file improvement pkg:compile pkg:plugin-config
Projects
None yet
2 participants