-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade vite to latest 4.x version #351
Comments
After further investigation, I found that we'd need some fixes to get things working with the latest 3.x version (3.2.7), and similar fixes are needed for the latest 4.x (4.4.9). Since 4.x has been out for over 9 months, and they're getting ready for another major version bump to 5.x, it doesn't really make sense to hang on to 3.x any longer. There are a few specific places in the SDE repo that we make use of vite, which I'll summarize below for the record:
The one unsavory part of this change is the new workaround I've had to add in |
We're on an older version of vite (3.1.3), and dependabot suggests upgrading to the most recent 3.x version. I'm not quite ready to upgrade to 4.x (need to see whether there are any incompatibilities affecting
plugin-vite
, or if we can change the peer dependency spec there to be 3.x OR 4.x). So for now we should do the minimal change and upgrade to the latest 3.x version, which seems safe from my testing.The text was updated successfully, but these errors were encountered: