Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opening the upload panel should focus the URL input #7896

Closed
oleq opened this issue Aug 21, 2020 · 1 comment · Fixed by #8255
Closed

Opening the upload panel should focus the URL input #7896

oleq opened this issue Aug 21, 2020 · 1 comment · Fixed by #8255
Assignees
@pkwasnik
Labels
domain:ui/ux This issue reports a problem related to UI or UX. intro Good first ticket. package:image squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 37 (v23...

Comments

@oleq
Copy link
Member

oleq commented Aug 21, 2020

📝 Provide a description of the improvement

ATM when the user opens the panel, the focus remains in editable and there's no way to type the URL straight away. 

We could adopt the media embed (also: link insertion UI) UX in this matter and focus the field immediately to make it more user-friendly.

If you'd like to see this improvement implemented, add a 👍 reaction to this post.
@oleq oleq added type:improvement This issue reports a possible enhancement of an existing feature. package:image domain:ui/ux This issue reports a problem related to UI or UX. squad:core Issue to be handled by the Core team. labels Aug 21, 2020
@panr
Copy link
Contributor

panr commented Aug 21, 2020

Funny thing, because both features are implemented it the same way... 👍 Somehow "Insert image..." doesn't work...

@Reinmar Reinmar added type:bug This issue reports a buggy (incorrect) behavior. and removed type:improvement This issue reports a possible enhancement of an existing feature. labels Aug 26, 2020
@Reinmar Reinmar added this to the next milestone Aug 26, 2020
@oleq oleq added the intro Good first ticket. label Sep 9, 2020
@pkwasnik pkwasnik self-assigned this Oct 9, 2020
@pkwasnik pkwasnik mentioned this issue Oct 14, 2020
Merged
jodator added a commit that referenced this issue Oct 14, 2020
@jodator
Merge pull request #8255 from ckeditor/i/7896
25b3aec 
Fix (image): The URL input field will now be focused when the image dropdown is opened. Closes #7896.
@Reinmar Reinmar modified the milestones: next, iteration 37 Oct 20, 2020
@mlewand mlewand changed the title Consider focusing the URL input when the image upload panel shows up Opening the upload panel should focus the URL input Oct 23, 2020
@mlewand mlewand mentioned this issue Oct 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pkwasnik pkwasnik

Labels
domain:ui/ux This issue reports a problem related to UI or UX. intro Good first ticket. package:image squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 37 (v23.1.0)
Development

Successfully merging a pull request may close this issue.

Focusing the URL input when the image upload panel shows up ckeditor/ckeditor5
4 participants
@Reinmar @oleq @panr @pkwasnik