Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Focusing the URL input when the image upload panel shows up #8255

Merged
merged 2 commits into from
Oct 14, 2020
Merged

Focusing the URL input when the image upload panel shows up #8255

merged 2 commits into from
Oct 14, 2020

Conversation

pkwasnik
Copy link
Contributor

Suggested merge commit message (convention)

Fix (image): Focusing the URL input when the image upload panel shows up. Closes #7896.

Additional information

For example – encountered issues, assumptions you had to make, other affected tickets, etc.

@pkwasnik pkwasnik requested a review from jodator October 14, 2020 09:27
jodator
jodator suggested changes Oct 14, 2020
View reviewed changes
Copy link
Contributor

@jodator jodator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix works fine as tested 😃

Minor additions are needed to not lose the knowledge we gained during this ticket.

packages/ckeditor5-image/src/imageinsert/imageinsertui.js Show resolved Hide resolved
packages/ckeditor5-image/tests/imageinsert/imageinsertui.js Outdated Show resolved Hide resolved
jodator
jodator approved these changes Oct 14, 2020
View reviewed changes
Copy link
Contributor

@jodator jodator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks!

@jodator jodator merged commit 25b3aec into master Oct 14, 2020
@jodator jodator deleted the i/7896 branch October 14, 2020 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jodator jodator jodator approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Opening the upload panel should focus the URL input
2 participants
@pkwasnik @jodator