Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application menu bar #15894

Closed
oleq opened this issue Feb 21, 2024 · 0 comments · Fixed by #15893
Closed

Application menu bar #15894

oleq opened this issue Feb 21, 2024 · 0 comments · Fixed by #15893
Assignees
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:build-decoupled-document package:editor-classic package:ui type:feature This issue reports a feature request (an idea for a new functionality or a missing option).

Comments

@oleq
Copy link
Member

oleq commented Feb 21, 2024

📝 Provide a description of the new feature

The editor deserves a proper application menu because our current toolbar setup gets too crowded to navigate and manage.

Current approach:

image

Proposed approach:

image

If you'd like to see this feature implemented, add a 👍 reaction to this post.

@oleq oleq added type:feature This issue reports a feature request (an idea for a new functionality or a missing option). package:ui domain:ui/ux This issue reports a problem related to UI or UX. package:build-decoupled-document package:editor-classic labels Feb 21, 2024
oleq pushed a commit that referenced this issue Mar 1, 2024
Internal (horizontal-line): Added menu bar integration. Related to #15894.
oleq pushed a commit that referenced this issue Mar 1, 2024
Internal (page-break): Added menu bar integration. Related to #15894.
oleq pushed a commit that referenced this issue Mar 1, 2024
Internal (remove-format): Added menu bar integration. Related to #15894.
oleq pushed a commit that referenced this issue Mar 1, 2024
Internal (indent): Added menu bar integration. Related to #15894.
oleq pushed a commit that referenced this issue Mar 1, 2024
Internal (html-embed): Added menu bar integration. Related to #15894.
oleq added a commit that referenced this issue Mar 1, 2024
Internal (list): Added menu bar integration. Related to #15894.
oleq added a commit that referenced this issue Mar 1, 2024
Internal (basic-styles): Added menu bar integrations for the basic style features. Related to #15894.
oleq pushed a commit that referenced this issue Mar 7, 2024
Internal (ui): Added menu bar integration for export to PDF. Related to #15894, cksource/ckeditor5-commercial#6058.
oleq pushed a commit that referenced this issue Mar 8, 2024
Internal (code-block): Added menu bar integration. Related to #15894.
oleq pushed a commit that referenced this issue Mar 14, 2024
Internal (export-word): Added menu bar integration. Related to #15894. Related to cksource/ckeditor5-commercial#6075.
oleq pushed a commit that referenced this issue Mar 14, 2024
Internal (link): Added menu bar integration. Related to #15894.
oleq added a commit that referenced this issue Mar 20, 2024
Internal (font): Added menu bar integration for font family, size, color, and background color. Related to #15894.
oleq added a commit that referenced this issue Mar 20, 2024
…guage

Internal (language): Added menu bar integration. Related to #15894.
oleq added a commit that referenced this issue Mar 21, 2024
Internal (highlight): Added menu bar integration. Related to #15894.
oleq added a commit that referenced this issue Mar 21, 2024
Internal (alignment): Added menu bar integration. Related to #15894.
oleq added a commit that referenced this issue Mar 21, 2024
Internal (case-change): Added menu bar integration. Related to #15894.
oleq added a commit that referenced this issue Mar 22, 2024
Internal (track-changes): Added menu bar integration. Related to #15894.
oleq added a commit that referenced this issue Mar 22, 2024
Internal (comments): Add menu bar integration for comments archive. Related to #15894.
oleq added a commit that referenced this issue Mar 22, 2024
Internal (template): Add menu bar integration. Related to #15894.
oleq added a commit that referenced this issue Mar 28, 2024
Internal (ui,editor-classic): Streamlined the menu bar config normalization. Made the feature an opt-in in the `ClassicEditor`. Related to #15894.
oleq added a commit that referenced this issue Mar 28, 2024
Internal (editor-decoupled): Add menu bar to decoupled editor. Related to #15894.
oleq pushed a commit that referenced this issue Apr 2, 2024
Tests (classic-editor): Add tests for menu bar. Related to #15894.
oleq added a commit that referenced this issue Apr 2, 2024
Feature: Implemented the application menu bar that contains various options and commands for controlling and navigating the editor. Closes #15894.

MINOR BREAKING CHANGE (upload): The `FileDialogButtonView` class has been moved from `ckeditor5-upload` to `ckeditor5-ui`. Please update your import paths accordingly (was: `import { FileDialogButtonView } from 'ckeditor5/src/upload.js';`, is: `import { FileDialogButtonView } from 'ckeditor5/src/ui.js';`).

MINOR BREAKING CHANGE (theme-lark): The default vertical spacing around `ButtonView` in `ListItemView` (`--ck-list-button-padding`) has been reduced for better readability. This affects the presentation of various editor features that use this type of UI (headings, font size, font family, etc.). You can restore the previous value by setting `--ck-list-button-padding: calc(.2 * var(--ck-line-height-base) * var(--ck-font-size-base)) calc(.4 * var(--ck-line-height-base) * var(--ck-font-size-base));` in your custom styles sheet.
@CKEditorBot CKEditorBot added this to the iteration 73 milestone Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:build-decoupled-document package:editor-classic package:ui type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants