Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add menu bar integration to code block. #15967

Merged
merged 6 commits into from
Mar 8, 2024
Merged

Add menu bar integration to code block. #15967

merged 6 commits into from
Mar 8, 2024

Conversation

mremiszewski
Copy link
Contributor

Suggested merge commit message (convention)

Feature (code-block): Add menu bar integration. Related to #15894.

Additional information

For example – encountered issues, assumptions you had to make, other affected tickets, etc.

@mremiszewski mremiszewski requested a review from oleq March 4, 2024 11:42
@mremiszewski mremiszewski changed the base branch from master to ck/app-menu-bar March 4, 2024 11:42
oleq
oleq requested changes Mar 7, 2024
View reviewed changes
Copy link
Member

@oleq oleq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's something wrong with focusing the editing root and general discovery of execute in this integration. The menu bar should close

Screen.Recording.2024-03-07.at.11.29.04.mov

@oleq oleq merged commit 60d9205 into ck/app-menu-bar Mar 8, 2024
1 check was pending
@oleq oleq deleted the ck/app-menu-bar-code-block branch March 8, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleq oleq oleq requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mremiszewski @oleq