Add menu bar integration to highlight. #16035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleq
requested changes
Mar 15, 2024
There was a problem hiding this comment.
Everything works fine except for some visual issues:
- We need a separator (
ListSeparatorView) between markers and the remove button. - We need transparent fills for the main and active icons:
so they become this
I know a transparent fill is not the best UX for the active item but it's better than this. It will be resolved once we address the problem of checkboxes displayed next to active list items in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Internal (highlight): Add menu bar integration. Related to #15894.
Additional information
For example – encountered issues, assumptions you had to make, other affected tickets, etc.