This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
I/4992: Added support for creating a ViewCollection with initial views
#524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t for obsolete #locale property in the ViewCollection.
…to ViewCollection at a time.
This was referenced Oct 21, 2019
This was referenced Feb 26, 2020
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Feature: Added support for creating a
ViewCollectionwith initial views (see ckeditor/ckeditor5#4992).BREAKING CHANGE: The parameters of the
ViewCollection#constructorhave changed. Please refer to the API docs to learn more.BREAKING CHANGE: The obsolete
ViewCollection#localeproperty has been removed because it was not used anywhere in the codebase.I figured
VC#constructor:Localewhich wasn't used anywhere, I'm not sure why it existed in the first place (same with the#localeproperty)Requires ckeditor/ckeditor5-utils#309