This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
i/4992: Used the new Collection and View API to add multiple Views at a time #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jodator
suggested changes
Oct 30, 2019
| * @param {module:ui/colorgrid/colorgrid~ColorDefinition} item | ||
| * @param {Number} [index] The position of the item in the collection. The item | ||
| * is pushed to the collection when `index` is not specified. | ||
| * @param {...(module:ui/colorgrid/colorgrid~ColorDefinition)} items |
There was a problem hiding this comment.
I was looking at a similar construct in the uitls PR and AFAIC the () is not needed for at least primitives. Maybe in this case we could also drop them?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Internal: Used the new
CollectionandViewAPI to add multipleViewsat a time. See (see ckeditor/ckeditor5#4992).Additional information
Requires ckeditor/ckeditor5-ui#524.