Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Added support for initializing ViewCollection and BodyCollection items using a constructor #544

Closed
wants to merge 10 commits into from
Closed

Added support for initializing ViewCollection and BodyCollection items using a constructor #544

wants to merge 10 commits into from

Conversation

mlewand
Copy link
Contributor

@mlewand mlewand commented Feb 26, 2020 •
edited
Loading

⚠ created PR from a wrong branch, use #545 instead ⚠

@mlewand
Feature: View collection can now also be initialized though construct…
bfe8744 
…ion.

Ported changes from ckeditor/ckeditor5-utils#309 (1aac49db1ca9ea914f9fc44f00e295474faf3ed2).

Note this breaks BodyCollection integration, so there's more work to be done.
@mlewand
Internal: Restored locale support for BodyCollection to work correctly.
8843250
@mlewand
Internal: Locale instance is required only for BodyCollection - so th…
85da301 
…is is where it is added.

Next commit will remove locale handling from the ViewCollection class.
@mlewand
Revert "Internal: Restored locale support for BodyCollection to work …
d1e4ab7 
…correctly."

This reverts commit 8843250.
@mlewand
Tests: Added unit test coverage for BodyCollection constructor.
bcf5b4f
@mlewand
Internal: Collection now works on iterables.
eafba4e
@mlewand
Merge branch 'master' into i/6194
0e34bef
@mlewand
Merge branch 'master' into i/6194
8838e08
@mlewand
Docs: Views can be actually an iterable.
db27824
@mlewand mlewand changed the title ### Suggested merge commit message ([convention](https://github.com/ckeditor/ckeditor5-design/wiki/Git-commit-message-convention)) Added support for initializing ViewCollection and BodyCollection items using a constructor Feb 26, 2020
@coveralls
Copy link

coveralls commented Feb 26, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-1.7%) to 98.328% when pulling ab499c1 on i/6194 into 9ba69a1 on master.

@mlewand mlewand mentioned this pull request Feb 26, 2020
Merged
@mlewand mlewand added the pr:sub label Feb 26, 2020
@mlewand mlewand requested a review from oleq February 27, 2020 08:26
@mlewand
Copy link
Contributor Author

mlewand commented Feb 27, 2020

Not sure what's up with the code coverage as I'm having 100% CC both, when running UI module alone and all the tests (here technically it's 99.9% due to #6326):

UI module:

Chrome 80.0.3987 (Windows 10.0.0): Executed 868 of 868 SUCCESS (10.824 secs / 1.831 secs)

=============================== Coverage summary ===============================
Statements   : 100% ( 1575/1575 )
Branches     : 100% ( 604/604 )
Functions    : 100% ( 450/450 )
Lines        : 100% ( 1549/1549 )
================================================================================

all:

Chrome 80.0.3987 (Windows 10.0.0): Executed 13317 of 13339 (skipped 22) SUCCESS (6 mins 4.766 secs / 2 mins 5.142 secs)

=============================== Coverage summary ===============================
Statements   : 100% ( 18726/18726 )
Branches     : 99.99% ( 9621/9622 )
Functions    : 100% ( 4190/4190 )
Lines        : 100% ( 18447/18447 )
================================================================================

@mlewand mlewand marked this pull request as ready for review February 27, 2020 09:06
@mlewand mlewand mentioned this pull request Feb 27, 2020
Merged
@mlewand
Copy link
Contributor Author

mlewand commented Feb 27, 2020

Sorry, I created this PR using a wrong branch name. Use #545 instead.

@mlewand mlewand closed this Feb 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@oleq oleq Awaiting requested review from oleq

Assignees
No one assigned
Labels
pr:sub
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mlewand @coveralls