Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Show markers #7

Closed
scofalik opened this issue Feb 28, 2019 · 3 comments · Fixed by #74
Closed

Feature request: Show markers #7

scofalik opened this issue Feb 28, 2019 · 3 comments · Fixed by #74

Comments

@scofalik
Copy link

It would be awesome if the inspector would also show markers. Maybe have a small, scrollable window where you could select (all) / deselect (all) markers you want to display.

I was also thinking about LiveRanges and LivePositions. I sometimes need to follow how they change during debugging. However, these are:

  1. not named so I am not sure how useful that would be,
  2. there's no one place to fetch them from (like editor.model.markers).
@oleq
Copy link
Member

oleq commented Feb 28, 2019

I wanted to implement markers in the MVP but I figured they were hard to display using the tree component I developed for the inspector. If you think this is acceptable to display them like the selection (only [....], nothing in between like the color etc.) then it shouldn't be too much work.

@scofalik
Copy link
Author

I was thinking like the selection with some indication which marker is which. Either using colors (would fail for more markers) or with a name next to opening and closing bracket (then each bracket would be in a new line).

@Reinmar
Copy link
Member

Reinmar commented Feb 28, 2019

I talked with Olek already that the selection could perhaps be displayed in a better way than right now. Perhaps similar to how we display it in the real-time collaboration scenarios. Then we could also display markers.

@Mgsy Mgsy added this to the backlog milestone Sep 16, 2019
@oleq oleq mentioned this issue Mar 25, 2020
@oleq oleq closed this as completed in #74 Mar 26, 2020
oleq added a commit that referenced this issue Mar 26, 2020
Feature: Implemented markers preview in the "Model" tree. Implemented the "Markers" tab. Implemented support for multiple model/view ranges both in the trees and "Selection" tabs. Improved selection rendering in trees for smooth UX. Closes #12. Closes #7. Closes #68. Closes #73.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants