Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display all selection ranges #68

Closed
jodator opened this issue Nov 5, 2019 · 6 comments · Fixed by #74
Closed

Display all selection ranges #68

jodator opened this issue Nov 5, 2019 · 6 comments · Fixed by #74
Assignees

Comments

@jodator
Copy link
Contributor

jodator commented Nov 5, 2019

Currently inspector show only one range from a selection that covers most (if not all) of the possible user selection (on Chrome at least).

There are at least two cases where user can create multi-range selection:

  1. When using Firefox
  2. Select multiple blocks (via custom plugin)

Current status:

Peek 2019-11-05 12-03

As you can see on the gif above I've added the output of the getModelData() helper method below the editor.

@oleq
Copy link
Member

oleq commented Nov 18, 2019

Is there any editor feature that supports this ATM? Because it sounds like an edge case to me.

@mlewand mlewand added this to the backlog milestone Nov 18, 2019
@mlewand
Copy link
Contributor

mlewand commented Nov 18, 2019

From what I can tell is that Firefox is currently the only browser that allows you to make multiple selections. And this is the only (non-api) way to create multiple ranges.

@jodator
Copy link
Contributor Author

jodator commented Nov 18, 2019

@oleq no, but we're about to start working on one: ckeditor/ckeditor5#5684

@oleq
Copy link
Member

oleq commented Nov 18, 2019

Let's wait for some actual editor feature and develop this in parallel.

BTW it would be great if we did it together with #12.

@Reinmar
Copy link
Member

Reinmar commented Jan 29, 2020

Let's wait for some actual editor feature and develop this in parallel.

Like table selection? 😂

@oleq
Copy link
Member

oleq commented Feb 3, 2020

Like table selection? 😂

Well, yeah. Works for me 😛

@oleq oleq self-assigned this Mar 25, 2020
@oleq oleq mentioned this issue Mar 25, 2020
@oleq oleq closed this as completed in #74 Mar 26, 2020
oleq added a commit that referenced this issue Mar 26, 2020
Feature: Implemented markers preview in the "Model" tree. Implemented the "Markers" tab. Implemented support for multiple model/view ranges both in the trees and "Selection" tabs. Improved selection rendering in trees for smooth UX. Closes #12. Closes #7. Closes #68. Closes #73.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants