Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve selection rendering #12

Closed
Reinmar opened this issue Mar 4, 2019 · 3 comments · Fixed by #74
Closed

Improve selection rendering #12

Reinmar opened this issue Mar 4, 2019 · 3 comments · Fixed by #74

Comments

@Reinmar
Copy link
Member

Reinmar commented Mar 4, 2019

Do you think that this gif creates the right mental model of how the engine behaves?

inspector

To me it looks like the selection which is rendered before applying bold is significantly different than the one rendered after that. Which is not true – it's exactly the same selection with the same properties.

That's why I don't think that the selection should be displayed as if was placed before text nodes.

I'm not sure if this will work but I'd like to see a prototype of something like:

image

@Reinmar
Copy link
Member Author

Reinmar commented Mar 4, 2019

For me this ticket is very important because the role of the inspector will be much more significant in creating a mental model of CKEditor 5's internals than everything we'll ever write in the documentation.

@jodator
Copy link
Contributor

jodator commented Apr 17, 2019

Another idea for selection rendering. We might use something similar to show selection gravity:
Peek 2019-04-16 13-48

@mlewand
Copy link
Contributor

mlewand commented Apr 17, 2019

That's a nice idea, we'd need to make sure it's understandable for devs without additional docs. Something like a tooltip on hover would be sufficient.

@mlewand mlewand added this to the backlog milestone Sep 16, 2019
@oleq oleq mentioned this issue Mar 25, 2020
@oleq oleq closed this as completed in #74 Mar 26, 2020
oleq added a commit that referenced this issue Mar 26, 2020
Feature: Implemented markers preview in the "Model" tree. Implemented the "Markers" tab. Implemented support for multiple model/view ranges both in the trees and "Selection" tabs. Improved selection rendering in trees for smooth UX. Closes #12. Closes #7. Closes #68. Closes #73.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants