Group BAO - Remove secret param that was breaking groupNesting #26623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
The secret param was to block the original multisite design of nested groups .... but we probably should have done this right back then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The saga continues. See #25994 and #26200 and #26074 and #26260 for some background.
Before
In multisite mode, new groups will automatically be given the domain group as a parent. There appears to be no good reason for this, and the multisite extension passes in a secret param to disable it. That secret param (possibly due to recent refactoring) has the (probably unintended) consequence of disabling all processing of parent groups.
After
Bad default behavior removed. Secret param to disable the bad default behavior no longer needed.