Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Following PR-25994 and PR-26074 #26200

Merged
merged 3 commits into from
May 17, 2023
Merged

Conversation

samuelsov
Copy link
Contributor

Overview

In searchkit, deleting a group parents inline doesn't work.

Finishing the work started in #25994 and #26074

Before

Peek 17-04-2023 15-33

After

It works.

Technical Details

Move the deletion logic from the group form edit to the CRM_Contact_BAO_Group::create function

Not sure if we can assume that if we don't remove a parent, there is no need for cache refresh (assuming no for now) :

      // this is always required, since we don't know when a
      // parent group is removed
      CRM_Contact_BAO_GroupNestingCache::update();

@civibot
Copy link

civibot bot commented May 11, 2023

(Standard links)

@civibot civibot bot added the master label May 11, 2023
CRM/Contact/BAO/Group.php Outdated Show resolved Hide resolved
CRM/Contact/BAO/Group.php Outdated Show resolved Hide resolved
@colemanw
Copy link
Member

Ok, this looks pretty good now. The BAO is still weird and nonstandard but this is certainly an improvement.

Not sure if we can assume that if we don't remove a parent, there is no need for cache refresh (assuming no for now)

I think the answer is yes, now that both adding and removing are controlled by the same function, we can safely skip cache refreshing if neither operation was done. Feel free to add that to this PR or as a followup after this is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants