SearchKit - Support the Group.parents field
#25994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
Hmm that title looks like one of those teachable examples of why it matters where you put the comma |
This was referenced Apr 3, 2023
colemanw
changed the title
Group.parents field
|
@eileenmcnaughton I've updated the title to clarify that I'm not starting a SearchKit Support Group. |
…o-fk fields This adds a 2nd field to the schema with options.prefetch = false (the first being Campaigns) This time the field is serialized and not a real FK, but prefetch=false makes sense because of the potentially very large number of groups in the database.
|
@colemanw Mostly works but I'm not able to remove a parent once added (reproduced and dmaster) :
|
|
Ok thanks @samuelsov I'll do a followup PR to fix the inline-edit. |
|
@samuelsov it's a bug in the BAO. I haven't solved it but have made #26074 to clarify and document the problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Enables
Group.parentsfield to function correctly in SearchKit.Before
Create a Search for Groups. Add "Parents" column. It displays nothing.
After
Works.
Technical Details
This adds a 2nd field to the schema with
options.prefetch = false(the first being Campaigns) This time the field is serialized and not a real FK, butprefetch=falsemakes sense because of the potentially very large number of groups in the database. In order to accommodate that I enabled SK to lookup FK entity from thepseudoconstantmetadata, in case there are any more weird fields like this, they will work!Comments
This change subtly changes the way the "Campaign" column works, e.g. when doing a search for Contributions and showing "Campaigns" the
prefetch=falsepseudoconstant continues to not load options client-side, but now it does use the option list when rendering values (instead of a join) and it removes the confusing dual fields "Campaign ID" and "Campaign Title" in favor of just "Campaign". Requires #25995