-
-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove call to the dreaded replaceMultipleContributionTokens #21652
Remove call to the dreaded replaceMultipleContributionTokens #21652
Conversation
(Standard links)
|
2b093f3
to
5bcf707
Compare
Ok I take it this one supercedes #21524. Will take a look. |
@demeritcowboy it incorporates it - given it's mostly r-run testing might be better together. There is also a membership pdf tokens one - but that is probably a different testing process... |
Ok so a little part of the side of me that lives outside of civiworld is going to die with what I'm about to do with this PR, but I'm going to say merge-on-pass once the test is rebased which seems to be in conflict and not sure why github isn't showing that. Jenkins retest this please |
5bcf707
to
31f2eba
Compare
@demeritcowboy also a little part of |
@demeritcowboy @eileenmcnaughton should I merge this PR based on tag? or needs to be tested again as there were some changes after the PR was marked with MoP? |
woo hoo - that is the last call to |
Overview
Remove call to the dreaded replaceMultipleContributionTokens
Before
The horror the horror
After
Awful - but not calling legacy functions
Technical Details
This builds on #21524 to remove the last core usage of
replaceContributionTokens
Comments
@demeritcowboy I worked up the courage to tackle it https://docs.civicrm.org/user/en/latest/contributions/manual-receipts-and-thank-yous/#grouped-contribution-thank-you-letters
The test I worked with is
testGroupedThankYous
but there is another in that class