dev/core#2832 Switch membership pdf to use token processor #21521
Conversation
Replaces final instances of https://lab.civicrm.org/dev/core/-/issues/2832
|
(Standard links)
|
|
@demeritcowboy so my thinking is that the path on pdfs looks like
|
|
@magnolia61 I'm a bit blocked on the tokens PR you tried testing until #21584 is resolved -but if you had time to test this membership tokens one it would help unblock getting them working with pdf letters once that path is sorted |
| 'messageTemplate' => ['msg_html' => $html_message], | ||
| 'contactId' => $membership['contact_id'], | ||
| 'schema' => ['contactId', 'membershipId'], | ||
| 'tokenContext' => ['membershipId' => $membership['id']], |
| $html[] = CRM_Core_BAO_MessageTemplate::renderTemplate([ | ||
| 'messageTemplate' => ['msg_html' => $html_message], | ||
| 'contactId' => $membership['contact_id'], | ||
| 'schema' => ['contactId', 'membershipId'], |
There was a problem hiding this comment.
@eileenmcnaughton for my own knowledge what is the purpose of schema parameter in general?
There was a problem hiding this comment.
@monishdeb yeah - I'm hoping we can flush that out in the docs - it became required (in master) to tell the token processors which entities to resolve - I'm not sure if that is good or bad. I was going to turn my attention to in once the anomalies with the actual tokens were in hand
|
Tested the patch on local and didn't encounter any regression/breakage. Reviewed the patch and looks good. |
|
woo hoo - that's the last call to |
Overview
dev/core#2832 Switch membership pdf to use token processor
Replaces final instances of
replaceEntityTokenshttps://lab.civicrm.org/dev/core/-/issues/2832
Before
legacy function used for membership tokens
After
token processor used
Technical Details
Test cover in tests/phpunit/CRM/Member/Form/Task/PDFLetterTest.php
Note that the alterations to that test are for token changes previously documented here and for which we added a rule to prevent them being submitted
Also note that I updated the deprecated class with the same change in order to make it easier to see the function is no longer used
https://lab.civicrm.org/documentation/docs/sysadmin/-/merge_requests/318
Comments