dev/core#2851 Remove calls to replaceContributionTokens in contribution pdf letter task #21524
Conversation
|
(Standard links)
|
|
test this please |
eileenmcnaughton
force-pushed
the
cont_render
branch
2 times, most recently
from
c97af7a to
ec5ad2e
Compare
eileenmcnaughton
changed the title
eileenmcnaughton
changed the title
eileenmcnaughton
force-pushed
the
cont_render
branch
from
ec5ad2e to
aa7506a
Compare
eileenmcnaughton
force-pushed
the
cont_render
branch
from
aa7506a to
5dc031f
Compare
|
@demeritcowboy if you have any time to test this - it's probably the one I'm most blocked on at the moment |
| ' . CRM_Utils_System::url('civicrm/event/info', NULL, TRUE) . '&reset=1&id=1 | ||
| ' . CRM_Utils_System::url('civicrm/event/register', NULL, TRUE) . '&reset=1&id=1 | ||
| ' . CRM_Utils_System::url('civicrm/event/info', NULL, TRUE) . '&reset=1&id=1 | ||
| ' . CRM_Utils_System::url('civicrm/event/register', NULL, TRUE) . '&reset=1&id=1 |
There was a problem hiding this comment.
I'm confused by how changing the pdf for contribution thank you letters affects the event urls for scheduled event reminders? I admit I haven't followed it thru yet but maybe you already know the answer.
There was a problem hiding this comment.
ug I've forgotten - I think it must be this line
There was a problem hiding this comment.
oh yeah it is - that line is saying 'this is the html version I'm giving you' - which results in less change to the pdf output
|
I have tested the patch in my local and looks good to me. Reviewed the patch and the added unit-test capture the change accurately. @demeritcowboy do you have any concern for merging this PR? |
|
Thanks @monishdeb the other PR #21652 includes this one as a commit but it's good to have extra testing since there's a billion variations on thank-you letters. So I think if that other one is merged this could be closed. |
|
@monishdeb #21521 is still untested.... |
|
Hmm does that mean
Hmm ok, so I think I'll close this PR as the #21652 will be merged anyway.
|
|
@eileenmcnaughton @demeritcowboy I am closing this PR in favor of #21652 |
Overview
Remove calls to replaceContributionTokens in pdf letter task (for non-grouped contributions)
Before
Legacy method used to resolve contribution tokens in contribution pdf letter task
After
Token processor used - legacy style still used for 'multiple contribution tokens' - but I have a plan for that
Technical Details
Note the output of cancel_date & thankyou_date is now date style - I've updated the upgrade notes for this. I expect wanting non-formatted (or these tokens at all) would be pretty edge https://lab.civicrm.org/-/ide/project/documentation/docs/sysadmin/tree/case/-/
Comments
This builds on #21525 which also makes minor token changes (added to the same docs PR) - for those we are changing the token syntax not the output so we can block the old syntax & advertise the new