Remove unused variables in completeOrder()

[mattwire]

Overview

Pre for #15555 This removes unused variables from completeOrder() function.

Before

Unused variables being set in completeOrder() - more difficult to see where vars are actually being used.

After

Not set - easier to see where vars are actually being used.

Technical Details

Comments

Follow up to #15699

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[demeritcowboy]

Looks ok except for maybe one possibility which I'm not sure about because I'm not familiar with this area of code.

The previous elseif (!empty($contribution->_relatedObjects['membership'])) { clause would never run if there were participant related objects. Now the if will always check against membership because of the removal of if (!empty($contribution->_relatedObjects['participant'])) {.

The PR title doesn't say NFC but it seems like it was intended to be, so to be truly NFC the new if line would need to be if (empty($contribution->_relatedObjects['participant']) && !empty($contribution->_relatedObjects['membership'])) {

Otherwise though $input isn't passed by reference, and it's clear the $input member elements referenced here aren't used again in the rest of the function.

[mattwire]

@demeritcowboy Thanks for the review, I'm pretty sure it won't make a difference, but I've made the change you suggested as my priority is to remove the $participant->id from here

[demeritcowboy]

Cool. And the fixme comment is perfect - it's exactly the part I was unsure about - whether it could actually be removed completely. So looks good to me.

[eileenmcnaughton]

OK - yes I agree - we established previously that input does not need to be passed by reference & now that it is not we don't need to alter $input in this function. Merging

[eileenmcnaughton]

Looking into this I added a PR to remove a few more lines #15901