[REF] further removal of unnecessary params #15901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per @mattwiree digging here civicrm#15841 we don't need to set vars that are no longer used
|
(Standard links)
|
|
Seems OK to me, but would be best to have another set of eyes? |
|
@mattwire might take a look - he was the one that spotted the removal a few lines later |
|
Agreed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Removes a few lines of code that were not achieving anything
Before
Unused array properties calculated & set
After
No longer calculated
Technical Details
Per @mattwire digging here #15841
we don't need to set vars that are no longer used
Comments