Skip to content

Commit

Permalink
[REF] further removal of unnecessar params
Browse files Browse the repository at this point in the history
Per @mattwiree digging here civicrm#15841
we don't need to set  vars that are no longer used
  • Loading branch information
eileenmcnaughton committed Nov 21, 2019
1 parent eda4c59 commit b5b4e83
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions CRM/Contribute/BAO/Contribution.php
Original file line number Diff line number Diff line change
Expand Up @@ -4572,14 +4572,6 @@ public static function completeOrder($input, &$ids, $objects, $transaction, $con
CRM_Contribute_BAO_ContributionRecur::addrecurSoftCredit($objects['contributionRecur']->id, $contribution->id);
}

$contributionStatuses = CRM_Core_PseudoConstant::get('CRM_Contribute_DAO_Contribution', 'contribution_status_id', [
'labelColumn' => 'name',
'flip' => 1,
]);
if (isset($input['prevContribution']) && (!$input['prevContribution']->is_pay_later && $input['prevContribution']->contribution_status_id == $contributionStatuses['Pending'])) {
$input['payment_processor'] = $paymentProcessorId;
}

if (empty($contribution->_relatedObjects['participant']) && !empty($contribution->_relatedObjects['membership'])) {
// @fixme Can we remove this if altogether? - we removed the participant if / else and left relatedObjects['participant'] to ensure behaviour didn't change but it is probably not required.
// @todo - use getRelatedMemberships instead
Expand Down

0 comments on commit b5b4e83

Please sign in to comment.