Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: add renovate to replace dependabot #1036

Merged
merged 2 commits into from
Jun 6, 2023
Merged

deps: add renovate to replace dependabot #1036

merged 2 commits into from
Jun 6, 2023

Conversation

mtardy
Copy link
Member

@mtardy mtardy commented May 30, 2023 •
edited
Loading

  • run renovate self-hosted on GitHub action with a workflow in order to use PostUpgradeCommands to commit generated files in deps update PRs.
  • install docker CLI plugin buildx in the renovate container in order for our PostUpgradeCommands to work.
  • use 'cilium-renovate' GitHub application in order to generate a fine grain permissions token.
  • group some deps update together in a single PR.
  • add a workflow to validate configuration change in PRs.

I had to merge renovatebot/github-action#749 to make our commands work in the renovate container.

This will provide us a lot more control over our deps update bot, and a lot more configuration settings (since we are running it ourselves on top of changing from dependabot to renovate).

When the renovate deployment works, we can disable Dependabot.

@mtardy mtardy added kind/enhancement This improves or streamlines existing functionality area/ci Related to CI labels May 30, 2023
@mtardy mtardy requested review from willfindlay and a team as code owners May 30, 2023 15:31
@cilium cilium deleted a comment from netlify bot May 30, 2023
michi-covalent
michi-covalent approved these changes May 31, 2023
View reviewed changes
Copy link
Contributor

@michi-covalent michi-covalent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 ➡️ 🤖

kkourt
kkourt reviewed May 31, 2023
View reviewed changes
Copy link
Contributor

@kkourt kkourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Will all the changes be in a single commit?

install/kubernetes/test.sh Outdated Show resolved Hide resolved
@mtardy
Copy link
Member Author

mtardy commented May 31, 2023

Will all the changes be in a single commit?

I could split by files since we have workflows and renovate config but since this is the initial config it feels a bit weird to split down the process of creating this configuration in multiple commits. If you have a specific idea in mind, we can do anything :)

@kkourt
Copy link
Contributor

kkourt commented May 31, 2023

Will all the changes be in a single commit?

I could split by files since we have workflows and renovate config but since this is the initial config it feels a bit weird to split down the process of creating this configuration in multiple commits. If you have a specific idea in mind, we can do anything :)

Sorry, I meant whether the generated PRs will have a single commit.

kkourt
kkourt approved these changes May 31, 2023
View reviewed changes
Copy link
Contributor

@kkourt kkourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 🚀 🎉

At what point we can disable dependabot? 👿

@mtardy
Copy link
Member Author

mtardy commented May 31, 2023

Will all the changes be in a single commit?

I could split by files since we have workflows and renovate config but since this is the initial config it feels a bit weird to split down the process of creating this configuration in multiple commits. If you have a specific idea in mind, we can do anything :)

Sorry, I meant whether the generated PRs will have a single commit.

Ah 😅. Yes generated PR are mono commit, even for grouping ones. But we can choose which one should be grouped and I chose:

  • all GitHub actions
  • go deps from api/go.mod

@mtardy
Copy link
Member Author

mtardy commented May 31, 2023

At what point we can disable dependabot? 👿

Once we merge this and see this working I guess 😄! Let's delay the merging by a day since I'm traveling today and won't be available if there's an issue.

mtardy added 2 commits May 31, 2023 09:39
@mtardy
helm: fix linter script to be portable
7db8d63 
- use docker to run kubeval instead of local install
- make the script cd into its current directory so that we can run it
  from anywhere
- add `set -o pipefail` bash option

Signed-off-by: Mahe Tardy <[email protected]>
@mtardy
deps: add renovate to manage dependencies updates
21f7f66 
- run renovate self-hosted on GitHub action with a workflow in order to
  use PostUpgradeCommands to commit generated files in deps update PRs.
- install docker CLI plugin buildx in the renovate container in order
  for our PostUpgradeCommands to work.
- use 'cilium-renovate' GitHub application in order to generate a fine
  grain permissions token.
- group some deps update together in a single PR.
- add a workflow to validate configuration change in PRs.

Signed-off-by: Mahe Tardy <[email protected]>
@aanm aanm mentioned this pull request Jun 2, 2023
Closed
8 tasks
@mtardy mtardy merged commit a3339bb into cilium:main Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkourt kkourt kkourt approved these changes

@willfindlay willfindlay willfindlay approved these changes

@michi-covalent michi-covalent michi-covalent approved these changes

Assignees
No one assigned
Labels
area/ci Related to CI kind/enhancement This improves or streamlines existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mtardy @kkourt @willfindlay @michi-covalent