Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create main.yml as a renovate bot for github actions #25504

Closed
wants to merge 2 commits into from
Closed

Create main.yml as a renovate bot for github actions #25504

wants to merge 2 commits into from

Conversation

swastik959
Copy link

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

Fixes: #25457

NONE

Signed-off-by: Swastik Gour <[email protected]>
@swastik959 swastik959 requested review from a team as code owners May 17, 2023 09:54
@swastik959 swastik959 requested a review from nbusseneau May 17, 2023 09:54
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 17, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label May 17, 2023
Copy link
Member

@nbusseneau nbusseneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! I am a bit confused, can you clarify what the PR is trying to achieve? 🤔 For information we already have Renovate watching over our GitHub Actions (see https://github.com/cilium/cilium/blob/main/.github/renovate.json5).

@swastik959
Copy link
Author

@nbusseneau oh it is there so that means in this issue I only have have add a script to the renovate.json5

@nbusseneau
Copy link
Member

Sorry, I'm still not sure what you're trying to achieve 😅 Perhaps you can give some more details? Would be helpful so that you don't waste time implementing something that might already be there.

Copy link
Member

@aanm aanm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes but I believe we need a PR similar to cilium/tetragon#1036 made into Cilium

@maintainer-s-little-helper
Copy link

Commit 524bc3d does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

1 similar comment
@maintainer-s-little-helper
Copy link

Commit 524bc3d does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. labels Jun 17, 2023
@swastik959 swastik959 closed this by deleting the head repository Jun 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. kind/community-contribution This was a contribution made by a community member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add renovate bot as a GitHub action
3 participants