Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add mount-docker-socket option #749

Merged
merged 4 commits into from
May 26, 2023
Merged

feat: add mount-docker-socket option #749

merged 4 commits into from
May 26, 2023

Conversation

mtardy
Copy link
Contributor

@mtardy mtardy commented May 24, 2023

Default to false. If set to true the action will mount the Docker socket inside the renovate container so that the commands can use Docker. Also set the user to root and group docker for permission. Can be useful for postUpgradeTasks's commands.

The auto-format touched an unrelated line and the automated format on git commit prevented me for removing it from this patch.

src/renovate.ts Outdated Show resolved Hide resolved
src/renovate.ts Outdated Show resolved Hide resolved
action.yml Outdated Show resolved Hide resolved
@viceice
Copy link
Member

viceice commented May 25, 2023

The unrelated change is fixed 🤗

README.md Outdated Show resolved Hide resolved
src/renovate.ts Outdated Show resolved Hide resolved
@mtardy mtardy requested a review from viceice May 25, 2023 09:15
Default to false. If set to true the action will mount the Docker socket
inside the renovate container so that the commands can use Docker. It
will also add the user inside of the renovate container to the Docker
group so that it has the right permissions to connect to the socket.
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please don't force-push if possible.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/renovate.ts Outdated Show resolved Hide resolved
@mtardy mtardy requested a review from viceice May 25, 2023 10:15
@mtardy mtardy changed the title feat: add mountDockerSocket option feat: add mount-docker-socket option May 25, 2023
src/input.ts Outdated Show resolved Hide resolved
src/renovate.ts Outdated Show resolved Hide resolved
src/renovate.ts Outdated Show resolved Hide resolved
@mtardy mtardy requested a review from viceice May 26, 2023 10:39
@mtardy
Copy link
Contributor Author

mtardy commented May 26, 2023

Hey, do you need me to do something to this before merging? :) Thanks

@viceice viceice enabled auto-merge (squash) May 26, 2023 17:29
@viceice viceice merged commit 7c65b94 into renovatebot:main May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants