-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add mount-docker-socket option #749
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viceice
requested changes
May 24, 2023
The unrelated change is fixed 🤗 |
viceice
reviewed
May 25, 2023
Default to false. If set to true the action will mount the Docker socket inside the renovate container so that the commands can use Docker. It will also add the user inside of the renovate container to the Docker group so that it has the right permissions to connect to the socket.
viceice
reviewed
May 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please don't force-push if possible.
viceice
reviewed
May 25, 2023
viceice
approved these changes
May 26, 2023
Hey, do you need me to do something to this before merging? :) Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default to false. If set to true the action will mount the Docker socket inside the renovate container so that the commands can use Docker. Also set the user to root and group docker for permission. Can be useful for postUpgradeTasks's commands.
The auto-format touched an unrelated line and the automated format on
git commit
prevented me for removing it from this patch.