connectivity: Automatically install IP routes on nodes w/o Cilium for from CIDR tests AND get rid of --datapath #1579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brb
force-pushed
the
pr/brb/conn-external-detect
branch
from
4f5c2a8 to
28324be
Compare
brb
force-pushed
the
pr/brb/conn-external-detect
branch
from
a610468 to
efd74a7
Compare
brb
added a commit
to cilium/cilium
that referenced
this pull request
May 11, 2023
We need to install extneral CIDR routes for the encryption tests, as the previous ones are deleted by "kind delete cluster". The boilerplate will go away once cilium/cilium-cli#1579 has been merged. Signed-off-by: Martynas Pumputis <[email protected]>
brb
force-pushed
the
pr/brb/conn-external-detect
branch
from
d65f42b to
3cb290c
Compare
brb
force-pushed
the
pr/brb/conn-external-detect
branch
from
3cb290c to
d59a51f
Compare
brb
force-pushed
the
pr/brb/conn-external-detect
branch
from
d59a51f to
907dfb0
Compare
brb
force-pushed
the
pr/brb/conn-external-detect
branch
from
0d44369 to
c25eeb0
Compare
brb
force-pushed
the
pr/brb/conn-external-detect
branch
from
c25eeb0 to
f7446e4
Compare
brb
force-pushed
the
pr/brb/conn-external-detect
branch
from
f7446e4 to
ccfeae5
Compare
brb
force-pushed
the
pr/brb/conn-external-detect
branch
from
ccfeae5 to
e67f7c6
Compare
brb
changed the title
brb
force-pushed
the
pr/brb/conn-external-detect
branch
from
a648e31 to
8d91077
Compare
brb
force-pushed
the
pr/brb/conn-external-detect
branch
from
8d91077 to
2f020a4
Compare
|
Successful CI run - cilium/cilium#25638. The Go linter failure is a red-herring. |
christarazi
approved these changes
May 24, 2023
viktor-kurchenko
approved these changes
May 25, 2023
This commit splits the host-netns deamonset into two - one which runs on
nodes which runs Cilium ("host-netns"), and one which runs on non-Cilium
test nodes selected with "--nodes-without-cilium"
("host-netns-non-cilium").
This is required, so that we grant NET_ADMIN only to the latter.
Signed-off-by: Martynas Pumputis <[email protected]>
brb
force-pushed
the
pr/brb/conn-external-detect
branch
from
2f020a4 to
f91c327
Compare
I've tried squashing it, but hit many merge conflicts. Anyway, I think having two separate commits gives a good understanding to a reader about our preference for granting permissions in a fine-grained manner. |
brb
added
the
ready-to-merge
|
Got majority of ACKs. All CI has passed. Merging to unblock other PRs. |
brb
added a commit
to cilium/cilium
that referenced
this pull request
May 26, 2023
This allows us to drop the external-from-cidrs detection, and also drop the "--datapath" connectivity test, as it was merged into the main connectivity suite. Both were done in [1]. [1]: cilium/cilium-cli#1579 Signed-off-by: Martynas Pumputis <[email protected]>
brb
added a commit
to cilium/cilium
that referenced
this pull request
May 26, 2023
[1] has fixed skipping some tests which previously was failing on v1.13. [1]: cilium/cilium-cli#1579 Signed-off-by: Martynas Pumputis <[email protected]>
brb
added a commit
to cilium/cilium
that referenced
this pull request
May 30, 2023
This allows us to drop the external-from-cidrs detection, and also drop the "--datapath" connectivity test, as it was merged into the main connectivity suite. Both were done in [1]. [1]: cilium/cilium-cli#1579 Signed-off-by: Martynas Pumputis <[email protected]>
brb
added a commit
to cilium/cilium
that referenced
this pull request
May 30, 2023
[1] has fixed skipping some tests which previously was failing on v1.13. [1]: cilium/cilium-cli#1579 Signed-off-by: Martynas Pumputis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a few changes:
--datapath, and introduces--include-unsafe-tests. The formal removal required a few changes to the flow validation and skipping some tests to make it pass on some GHA workflows.Please review it per commit.
Successful run - cilium/cilium#25510.