-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci-e2e: backport changes in conformance-e2e into v1.13 tests #25386
Conversation
/ci-e2e-1.13 |
@thorn3r I think it picks from the |
@brb right forgot about that, ty! |
@@ -20,7 +20,7 @@ on: | |||
# will disappear from the PR checks: please provide a direct link to the | |||
# successful workflow run (can be found from Actions tab) in a comment. | |||
# | |||
# pull_request: {} | |||
pull_request: {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this remain commented?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope this was just to get the tests to run here
/ci-e2e |
/ci-e2e-1.13 |
@brb feel free to drop this commit if it's not what you had in mind. I can also move this to a new PR instead. |
Bring the conformance-e2e-v1.13 tests to parity with conformance-e2e. The changes made were prior to the renaming of conformance-datapath to conformance-e2e, so rather than backporting the commits this commit copies the changes into conformance-e2e-v1.13 Signed-off-by: Tim Horner <[email protected]> Signed-off-by: Martynas Pumputis <[email protected]>
9cfd669
to
a305ccf
Compare
@thorn3r Cool, that was my intention for a separate PR, as I didn't want to introduce that many changes to the already broken flow. But considering that all tests have passed (https://github.com/cilium/cilium/actions/runs/4955234361/jobs/8864455590?pr=25386), let's proceed with your changes 🎉 I applied a few small changes to your commit and cleaned up the rest. |
Latest run (all green): https://github.com/cilium/cilium/actions/runs/4955981127/jobs/8865913448 |
c0c4add
to
a305ccf
Compare
To unblock #25346 let's backport the whole conformance-e2e.yaml to conformance-e2e-v1.13.yaml.