connectivity: Get rid of --datapath #1559
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchaigno
reviewed
May 1, 2023
connectivity/suite.go
Outdated
| ct.NewTest("pod-to-pod-encryption"). | ||
| WithFeatureRequirements(check.RequireFeatureEnabled(check.FeatureEncryptionPod)). | ||
| WithScenarios( | ||
| tests.PodToPodEncryption(), |
There was a problem hiding this comment.
IIRC, this test won't work on EKS because we have multiple native interfaces there. Is that fixed now or is the feature detection somehow taking that into account?
Noup. Unfortunately, having code and tests in two different repos makes it unnecessarily difficult to do. Anyway, will try to run those tests. Thanks for pointing out. |
Let's simplify the test suite, and run the "--datapath" tests as part of the regular connectivity tests. The built-in feature detection will skip those if the conditions cannot be met. Signed-off-by: Martynas Pumputis <[email protected]>
|
Preceded by #1579. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's simplify the test suite, and run the "--datapath" tests as part of the regular connectivity tests. The built-in feature detection will skip those if the conditions cannot be met.