Team/hypothesis tests #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lidation Allow capital letters in collection names
This reverts commit f48a07a. Going to use a different approach.
Saves a lot of time during testing by not re-constructing them all the time.
* Progress toward coverage * Updated assumptions * temporarily generate less data * use full-dimension records * Use recall thresholds for ann_invariant * Tests passing * Address comment * Fix buggy regex in index name check * Embale tests in vscode * Nit --------- Co-authored-by: Luke VanderHart <[email protected]>
Fixes for collections property tests
…ne-tests Collection state machine tests
Per PR review feedback
…-tests Apply Hypothesis tests as integration tests
Test unwrapped values
Fix glob syntax in CI config
Add in multiple versions of python during CI. Add typed_extensions which lets us patch back in types not supported in older versions
Adds a hypothesis test for filtering the query.
Validate duplicate IDs for JS client
Upsert support for JS
Add support for multiple distance metrics in tests. We coin-flip and sometimes add a space when using hnsw_params Added the distance functions to the invariant and use them when needed. In the process of writing this test I discovered a bug with our implementation of update that was revealed by the inner product space. Since the inner product is not a true metric, a point may not be a neighbor to itself. Our update code was strictly appending to the index due to the a bug with how we manage string UUID vs UUID objects. In l2 and cosine spaces, this usually was fine in the eyes of tests since the results returned were correct with the updated data. But IP exacerbated the issue by making the results not always be the same point.
Add PR checklist
* Hashing EF * Draf from EF strategy * debug * Remove test * Finalized tests * Restore logging message * Log accuracy threshold * Remove normalization, TODOs * Address comments * Fix list wrapping to pass docs to EF * Address comments
HammadB
commented
May 6, 2023
| @@ -143,6 +153,9 @@ def create_collection( | |||
|
|
|||
| if len(dupe_check) > 0: | |||
| if get_or_create: | |||
| if dupe_check[0][2] != metadata: | |||
There was a problem hiding this comment.
This behavior is confusing
HammadB
commented
May 6, 2023
| @@ -82,6 +82,10 @@ def create_collection( | |||
| dupe_check = self.get_collection(name) | |||
| if len(dupe_check) > 0: | |||
| if get_or_create is True: | |||
| if dupe_check[0][2] != metadata: | |||
There was a problem hiding this comment.
This behavior is confusing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Merges Team Hypothesis Tests
Test plan
These are tests.
Documentation Changes
None