Upsert support for JS #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffchuber
requested changes
Apr 20, 2023
jeffchuber
approved these changes
May 3, 2023
| return response.data; | ||
| }).catch(function ({ response }) { | ||
| return response.data; | ||
| }); |
There was a problem hiding this comment.
ill update this to use the new handleSuccess, handleError functions later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Regenerate the JS API and tweak it to correspond to the changes for Upsert introduced in #385
Test plan
Includes a unit test. Actual functionality is covered via the Python tests.
Documentation Changes
Included in chroma-core/docs#27