Add Upsert to Collection with Hypothesis tests #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levand
commented
Apr 19, 2023
levand
commented
Apr 19, 2023
HammadB
approved these changes
Apr 19, 2023
This was referenced Apr 20, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Adds
upsertmethod to public facing API, based off of Anton's previous work in #274 but retargeting our `team/hypothesis-tests branch.This is now a necessary API method: after merging #363
addwill now throw errors if duplicates are inserted.Test plan
Unit tests and Hypothesis tests.
Documentation Changes
chroma-core/docs#27