Validate add to prevent duplicate IDs.
#363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@levand let's find time to review in person |
HammadB
reviewed
Apr 17, 2023
HammadB
reviewed
Apr 17, 2023
levand
force-pushed
the
lukev/validate_add
branch
from
15643da to
25d451f
Compare
levand
commented
Apr 17, 2023
| metadatas: List[types.Metadata] | ||
| documents: List[types.Document] | ||
|
|
||
|
|
||
| class EmbeddingStateMachine(RuleBasedStateMachine): |
There was a problem hiding this comment.
Rename TestCollectionContents
There was a problem hiding this comment.
Can do as a separate PR.
levand
commented
Apr 17, 2023
| self._add_embeddings(embedding_set) | ||
| return multiple(*embedding_set["ids"]) | ||
| if set(embedding_set["ids"]).intersection(set(self.embeddings["ids"])): | ||
| with pytest.raises(ValueError): |
There was a problem hiding this comment.
Test that the value error is correct.
levand
commented
Apr 17, 2023
| @@ -129,8 +160,8 @@ def _add_embeddings(self, embeddings: strategies.EmbeddingSet): | |||
| else: | |||
| documents = [None] * len(embeddings["ids"]) | |||
|
|
|||
| self.embeddings["metadatas"].extend(metadatas) # type: ignore | |||
| self.embeddings["documents"].extend(documents) # type: ignore | |||
| self.embeddings["metadatas"] += metadatas # type: ignore | |||
levand
commented
Apr 17, 2023
| def test_dup_add(api): | ||
| api.reset() | ||
| coll = api.create_collection(name="foo") | ||
| with pytest.raises(ValueError): |
There was a problem hiding this comment.
Create more specific error type.
levand
force-pushed
the
lukev/validate_add
branch
from
35f93c2 to
693a53a
Compare
|
Reviewed in-person with @atroyn and incorporated feedback prior to merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Throw errors if the user attempts to add duplicate IDs, either via separate calls to
Collection.addor the same one.Test plan
This branch is based of #355 which contains failing tests for this functionality.
Documentation Changes
chroma-core/docs#42