This repository has been archived by the owner on May 10, 2024. It is now read-only.
Add docs to reflect duplicate ID validation #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should NOT be merged until the corresponding functionality in `lukev/validate_add` branch in `chromadb` gets merged to main.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@levand i think this can be merged now? |
|
@HammadB do you know if this can be merged? |
|
We can merge it for now. However the sqllite refactor will change this behavior to silently fail. |
|
@HammadB merged, can you link me to the discussion about silently failing? Seems like users will likely be making a mistake using duplicate ids and we should let them know vs silently fail. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should NOT be merged until the corresponding functionality in
lukev/validate_addbranch inchromadbgets merged to main.