Collection state machine tests #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levand
commented
Apr 10, 2023
chromadb/test/configurations.py
Outdated
| chroma_db_impl="duckdb+parquet", | ||
| persist_directory=tempfile.gettempdir() + "/tests", | ||
| ), | ||
| # Settings( |
There was a problem hiding this comment.
Temporarily disabled to make tests faster, will re-enable before merging.
levand
commented
Apr 10, 2023
chromadb/test/property/strategies.py
Outdated
|
|
||
| # TODO: build a strategy that constructs english sentences instead of gibberish strings | ||
| # Unsure what would happen feeding random unicode to an embedding model, could get bad results | ||
|
|
||
| document = st.from_type(Optional[str]) | ||
|
|
||
| _coll_name_re = re.compile(r"^[a-zA-Z][a-zA-Z0-9-]{1,61}[a-zA-Z0-9]$") | ||
| _coll_name_re = re.compile(r"^[a-zA-Z][a-zA-Z0-9-]{1,60}[a-zA-Z0-9]$") |
There was a problem hiding this comment.
this will also fail until we merge #302
HammadB
reviewed
Apr 10, 2023
| st.none(), | ||
| st.dictionaries( | ||
| st.text(), | ||
| st.one_of(st.text(), st.integers(), st.floats(allow_infinity=False, allow_nan=False)), |
There was a problem hiding this comment.
We should capture the fact that infinity / nan cannot be in metadata
HammadB
approved these changes
Apr 10, 2023
This reverts commit f48a07a. Going to use a different approach.
Saves a lot of time during testing by not re-constructing them all the time.
Fixes for collections property tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
New tests for collection manipulation using Hypothesis with a state machine.
Test plan
This change is the tests.
Documentation Changes
No user-facing documentation.