test: drop test-bin target #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current default target in test/Makefile is `test-bin` [1] as this is the first target in the makefile. This was unintentional change introduced in [2]. The default target should be `all`. However, `test-bin` does not appear to be used anywhere and thus, we can remove it. [1] https://www.gnu.org/software/make/manual/html_node/Rules.html [2] checkpoint-restore#71 Signed-off-by: Radostin Stoyanov <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #73 +/- ##
=======================================
Coverage 62.04% 62.04%
=======================================
Files 1 1
Lines 137 137
=======================================
Hits 85 85
Misses 37 37
Partials 15 15 Continue to review full report at Codecov.
|
snprajwal
reviewed
Jun 25, 2022
actions/setup-go modifies the PATH environment variable in order to make the go binaries will be available. However, this change is not applied to the root user as it is considered unsafe: actions/setup-go#104 Signed-off-by: Radostin Stoyanov <[email protected]>
adrianreber
approved these changes
Jun 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current default target in test/Makefile is
test-binas this is the first target in the makefile. This was unintentional change introduced in #71. The default target should beall. However,test-bindoes not appear to be used anywhere and thus, we can remove it.