Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: drop test-bin target #73

Merged
merged 2 commits into from
Jun 27, 2022
Merged

test: drop test-bin target #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca96749
test: drop test-bin target
rst0git Jun 24, 2022
288ce97
ci: fix go matrix tests running with sudo
rst0git Jun 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,16 +30,15 @@ jobs:
go-version: ${{ matrix.go-version }}

- name: Run tests
run: |
# Run actual test as root as it uses CRIU.
sudo make test
# Test magicgen script
make -C scripts test
run: sudo env "PATH=$PATH" make test

- name: Test magicgen script
run: make -C scripts test

- name: Check code coverage
if: matrix.go-version == '1.17.x' && matrix.criu_branch == 'criu-dev'
run: |
# Run actual test as root as it uses CRIU.
sudo make coverage
sudo env "PATH=$PATH" make coverage
# Upload coverage results to codecov
sudo -E make codecov
3 changes: 1 addition & 2 deletions test/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ export CRIU_FEATURE_MEM_TRACK CRIU_FEATURE_LAZY_PAGES CRIU_FEATURE_PIDFD_STORE
TEST_PAYLOAD := piggie/piggie
TEST_BINARIES := test $(TEST_PAYLOAD) phaul/phaul
COVERAGE_BINARIES := test.coverage phaul/phaul.coverage
test-bin: $(TEST_BINARIES)

all: $(TEST_BINARIES) phaul-test
mkdir -p image
Expand Down Expand Up @@ -79,4 +78,4 @@ clean:
@rm -f $(TEST_BINARIES) $(COVERAGE_BINARIES) codecov
@rm -rf image $(COVERAGE_PATH)

.PHONY: all clean coverage codecov phaul-test test-bin
.PHONY: all clean coverage codecov phaul-test