Add makefile for testing #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rst0git
force-pushed
the
test-makefile
branch
2 times, most recently
from
289b3d4 to
0e21146
Compare
Codecov Report
@@ Coverage Diff @@
## master #71 +/- ##
===========================================
+ Coverage 26.15% 62.04% +35.88%
===========================================
Files 11 1 -10
Lines 2015 137 -1878
===========================================
- Hits 527 85 -442
+ Misses 1390 37 -1353
+ Partials 98 15 -83
Continue to review full report at Codecov.
|
adrianreber
reviewed
Jun 22, 2022
snprajwal
reviewed
Jun 22, 2022
snprajwal
reviewed
Jun 22, 2022
Running tests with CRIU requires root privileges, however, building go binaries does not. This patch separates the build steps from the steps used to run tests. This allows to build applications such as crit using `make` without root privileges. Signed-off-by: Radostin Stoyanov <[email protected]>
Signed-off-by: Radostin Stoyanov <[email protected]>
adrianreber
approved these changes
Jun 23, 2022
rst0git
added a commit
to rst0git/go-criu
that referenced
this pull request
Jun 24, 2022
The current default target in test/Makefile is `test-bin` [1] as this is the first target in the makefile. This was unintentional change introduced in [2]. The default target should be `all`. However, `test-bin` does not appear to be used anywhere and thus, we can remove it. [1] https://www.gnu.org/software/make/manual/html_node/Rules.html [2] checkpoint-restore#71 Signed-off-by: Radostin Stoyanov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running tests with CRIU requires root privileges, however, building go binaries does not. This patch separates the build steps from the steps used to run tests. This allows to build applications such as crit using
makewithout root privileges.