Migrate to Chart.js v3.0.0-beta.7 #203
Conversation
|
@simonbrunel it's official that CHART.JS 3 will drop IE11 support. See issue chartjs/Chart.js#8042 and PR chartjs/Chart.js#8009. |
There was a problem hiding this comment.
Thanks to everyone who contributed to that PR 👍
Before going further, we will need to get rid of everything not related to v3 (such as the dependencies update). You can either submit a PR against master if you would like it for that PR, or simply drop it. I will also need the docs / samples to be deployed so I can check that nothing is broken in case it's not covered by unit tests.
Edit: I will have a look on updating all dependencies in master.
Fixed typings Fixed unit-tests Allow es-2015
Configured linting to allow for Promise globals in gulpfile.js and tests
santam85
force-pushed
the
chartjs-next
branch
from
d6273a8 to
32d71a6
Compare
|
@simonbrunel about the update of labels, I have create the use case.
The "top" labels will be showed only if there is an update or hovering a dataset item.
Let me know if you think it's a bug in order to submit an issue. |
@stockiNail It could be related to this: #203 (comment) |
@kurkle apologize, I have written here to avoid to forget it, my memory is not so persistent. I'm gonna wait for the merge into the branch of the project (or into the master) and then I'll submit it. |
santam85
force-pushed
the
chartjs-next
branch
from
4016b95 to
7b9e760
Compare
Fixed typings Fixed unit-tests Allow es-2015
santam85
changed the title
| datasets: [ | ||
| { | ||
| data: [], |
There was a problem hiding this comment.
@etimberg @kurkle it looks like the TS definition of the core library enforces passing data.labels and data.datasets[i].data. I don't remember if the library needs them in case of an empty chart (I thought undefined values was correctly handled). And for labels, I'm wondering if all charts really need this input (e.g. scatter/bubble charts).
|
@santam85 3 samples are broken and I think it's related to chartjs/Chart.js/issues/8145. |
|
@santam85 Can you give me write permissions to your fork so I can push more commits to this PR? |
You should have now, i enabled access to mantainers |
|
@santam85 @sgratzl @stockiNail Thank you so much for all your hard work on migrating this plugin to Chart.js v3! I still need to address a few things in master and then rebase the |
|
@simonbrunel Is there a way to pull down the beta for testing from NPM for datalabels? |
|
@mschlitz-trux I will as soon as the following points are fixed:
|
New PR including all changes present in #181 and #202 (sorry, couldn't restore that branch)
Removed ES6 features in library code.
Closes #180