Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with Chart js 3.0 #180

Closed
sk0gen opened this issue May 22, 2020 · 10 comments · Fixed by #203
Closed

Compatibility with Chart js 3.0 #180

sk0gen opened this issue May 22, 2020 · 10 comments · Fixed by #203

Comments

@sk0gen
Copy link

sk0gen commented May 22, 2020

Do you have any plans to add next version compatibile with Chart.Js@next(3.0)?

@stockiNail
Copy link
Contributor

+1

@stockiNail
Copy link
Contributor

I'm preparing my app to use Chart.Js 3 but I'm also using datalabels plugin.
Is there any idea when new version (also pre-release in order to test whole app) could be available?
Thanks a lot!

@benmccann
Copy link

I noticed that src/utils.js and src/label.js in the chartjs-next branch do import Chart from 'chart.js';. This is something that chartjs-chart-financial currently does as well where @etimberg suggested it needs to be import { Chart } from 'chart.js';.

@santam85
Copy link
Contributor

@benmccann fixed that in #214

@simonbrunel
Copy link
Member

@santam85 @stockiNail I rebased the chartjs-next branch on master and squashed commits in 2 major changes:

  • Update to Chart.js v3.0.0-beta.13 (f40336b)
  • Convert the plugin to ESM (04fe725)

Hopefully, I didn't break anything :)

Can you please checkout and test the chartjs-next branch so I can release v2.0.0-beta.1 (probably tomorrow)?

@stockiNail
Copy link
Contributor

@simonbrunel rebased! Thank you!

@santam85
Copy link
Contributor

@simonbrunel tested successfully in ng2-charts, apart from the legend/tooltip issue you noticed in the docs, everything else seems to check out! Thanks in advance for releasing this!

@simonbrunel
Copy link
Member

@santam85 did you checkout a clean version of the latest chartjs-next branch? the legend/tooltip issue should be fixed.

@santam85
Copy link
Contributor

@santam85 did you checkout a clean version of the latest chartjs-next branch? the legend/tooltip issue should be fixed.

You're right, I had a stale instance of vuepress still running, and new ones pick a different port automatically. That's fixed as well!

@simonbrunel
Copy link
Member

v2.0.0-beta.1 is released! 🚀

I'm closing this issue in favor of #213.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants