Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chart Js 3.0 update #1214

Closed
abannsunny opened this issue Mar 27, 2020 · 20 comments · Fixed by #1276
Closed

chart Js 3.0 update #1214

abannsunny opened this issue Mar 27, 2020 · 20 comments · Fixed by #1276
Assignees

Comments

@abannsunny
Copy link

abannsunny commented Mar 27, 2020

Hi

I was wondering if there are any plans to update ng2-charts to support the chart.js 3.0 release.

Thank you.

@Souffd
Copy link

Souffd commented Apr 16, 2020

It would be nice to upgrade to charts.js 3.0

@cyberluke
Copy link

Copy that!

@paviad
Copy link
Contributor

paviad commented Aug 25, 2020

@santam85 do you think you can handle this? :)

@santam85
Copy link
Contributor

santam85 commented Sep 4, 2020

@paviad sure thing! If you can get me access to the applitools project (even readonly) It would help a lot to reduce regressions though...

@paviad
Copy link
Contributor

paviad commented Sep 5, 2020

@santam85 Can we just create new applitools workspace and ditch the old one? Not getting any response from the owner @valorkin

@santam85
Copy link
Contributor

santam85 commented Sep 7, 2020

Sure we can, we'd loose any baseline comparison though, and there is a cost involved if we want a plan that allows access to multiple people as a team

@santam85
Copy link
Contributor

santam85 commented Oct 8, 2020

Quick update here: I have a working version of the library updated to Chart.js 3.0 beta 3
Will push the WIP to a branch soon for review, because some small changes to the APIs were needed due to breaking changes in Chart.js

@valorkin
Copy link
Member

valorkin commented Oct 8, 2020

@santam85 well done!

@jordancue
Copy link

Any update on this issue?

@santam85
Copy link
Contributor

santam85 commented Jan 4, 2021

@schwenkreis
Copy link

Sorry, I did not recognize this issue. Please close #1292 and thanks a lot for working on this!

@7amou3
Copy link

7amou3 commented Mar 21, 2021

hello, any news on charjs v3?

@santam85
Copy link
Contributor

hello, any news on charjs v3?

Have a look at PR #1276
The Chart.js team has just released rc.2, and work has been done on the datalabels and annotation plugins (on which this library depends on) to make them compatible. Only a couple of visual tests are now failing (mostly related to the annotation plugin), but I expect to be able to quickly fix everything after the final 3.0 version of chart.js is out.

@jordankkk
Copy link

3.0 is released 😃

@vibonacci
Copy link

Is it safe to use the dev-3 branch? The PR seems approved.

@santam85
Copy link
Contributor

santam85 commented Apr 8, 2021

Is it safe to use the dev-3 branch? The PR seems approved.

@vibonacci not all dependencies have a stable and released Chart.js v3.0 compatible version (datalabel and financial charts), but in general what's on the branch works correclty.
I am in the process of getting it released under the next tag, while I finish up documentation work and the transitive deps release a final version.

@SteveKennedy
Copy link

SteveKennedy commented Apr 15, 2021

How would I go about using the dev-3 branch in my package.json?

I have: "ng2-charts": "valor-software/ng2-charts#dev-3"

But when I run npm install, it eventually errors with: Not Found - GET https://registry.npmjs.org/chartjs-chart-financial - Not found

@santam85
Copy link
Contributor

How would I go about using the dev-3 branch in my package.json?

I have: "ng2-charts": "valor-software/ng2-charts#dev-3"

But when I run npm install, it eventually errors with: Not Found - GET https://registry.npmjs.org/chartjs-chart-financial - Not found

Unfortunately specifying the dependency like that will not work as the repo is currently using a git submodule. I am ready to push the required changes to make it work, but we need chartjs/chartjs-chart-financial#95 to be merged first, as there isn't any compatible release of that library.

Manual checkout and linking is needed if you want to test this branch.

@redsuperbat
Copy link

Hello!
Any news on this update? Anything I can do to thelp?
Best Reagards

@santam85
Copy link
Contributor

Hello!
Any news on this update? Anything I can do to thelp?
Best Reagards

Hey there, mainly chartjs/chartjs-chart-financial#95, and access for me to publish this on NPM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.