-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chart Js 3.0 update #1214
Comments
It would be nice to upgrade to charts.js 3.0 |
Copy that! |
@santam85 do you think you can handle this? :) |
@paviad sure thing! If you can get me access to the applitools project (even readonly) It would help a lot to reduce regressions though... |
Sure we can, we'd loose any baseline comparison though, and there is a cost involved if we want a plan that allows access to multiple people as a team |
Quick update here: I have a working version of the library updated to Chart.js 3.0 beta 3 |
@santam85 well done! |
Any update on this issue? |
@jordancue waiting for chartjs/chartjs-plugin-datalabels#180 |
Sorry, I did not recognize this issue. Please close #1292 and thanks a lot for working on this! |
hello, any news on charjs v3? |
Have a look at PR #1276 |
3.0 is released 😃 |
Is it safe to use the dev-3 branch? The PR seems approved. |
@vibonacci not all dependencies have a stable and released Chart.js v3.0 compatible version (datalabel and financial charts), but in general what's on the branch works correclty. |
How would I go about using the dev-3 branch in my package.json? I have: "ng2-charts": "valor-software/ng2-charts#dev-3" But when I run npm install, it eventually errors with: Not Found - GET https://registry.npmjs.org/chartjs-chart-financial - Not found |
Unfortunately specifying the dependency like that will not work as the repo is currently using a git submodule. I am ready to push the required changes to make it work, but we need chartjs/chartjs-chart-financial#95 to be merged first, as there isn't any compatible release of that library. Manual checkout and linking is needed if you want to test this branch. |
Hello! |
Hey there, mainly chartjs/chartjs-chart-financial#95, and access for me to publish this on NPM |
Hi
I was wondering if there are any plans to update ng2-charts to support the chart.js 3.0 release.
Thank you.
The text was updated successfully, but these errors were encountered: