Drop legacy browser support #8009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -15.8 kB (7%) ✅ Total Size: 213 kB
ℹ️ View Unchanged
|
|
Interesting idea. Not sure what impact this might have these days |
|
It might be nice to document how users can build their own legacy version from the ESM build (what polyfills, babel settings, etc. are needed). That documentation would probably be helpful for npm users even if we end up keeping this |
etimberg
previously approved these changes
Nov 6, 2020
etimberg
previously approved these changes
Nov 12, 2020
etimberg
previously approved these changes
Nov 12, 2020
|
looks like the sourcemap is not correctly mapped in the coverage. i'll investigate a bit more |
|
ok, coverage working the same now |
etimberg
approved these changes
Nov 12, 2020
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missed the button, was supposed to be draft.
Another option would be to add a
chart.legacy.jsor something, that would allow tracking usage of the dead weight.