Version 2.7.0 #4706
Merged
Version 2.7.0 #4706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new tooltip callback `labelTextColor` that returns the colour for each item in the body of the tooltip. Fixes issue #4191
Fix onHover event not being triggered The core controller was looking at the wrong object (options.hover) to find the function to be called on hover. The function is provided on the top level options object (options.onHover). By using the helper function, there's no need to verify if the callback is defined, as the helper already does that. Fixes #4296
Implemented alignment by major unit in the time scale. This allows showing the first tick of a larger unit like days in a special way and is part of the basis of the time series scale.
Ensure that disabled legend style is drawn in the center of the text and that the text is correctly centered in the box.
See discussion in the issue for context and possible approaches. When invoking update() inside an event handler, such as onHover, `options.hover.animationDuration` was not being respected. Given that some use cases may require additional animation properties for the manual update call, this commit changes that method signature to accept a configuration object. This object provides backwards compatibility with duration and lazy properties, and also introduces the easing property so that the event animation is different from the global one. Add tests that guarantee that when update is called manually with arguments, it properly builds the _bufferedRequest or calls render with the proper arguments. It includes test cases for when update is called with legacy arguments (duration and lazy) instead of the config object. .update() documentation was previously updated but .render() was left out. Since the backwards compatible change was also made to render(), this commit adds documentation for it.
Working towards creating the TimeSeries scale, this PR adds formatting for major and minor ticks on axes.
According to the (issue tracker of highcharts)[highcharts/highcharts#4405 (comment)] they do not consider the code open source. It's available for reading but that's about it. The code is provided under CC-BY-NC via github. See also: https://shop.highsoft.com/faq#Non-Commercial-0
correct wording error
Elements were resizing incorrectly if they were regenerated while the chart was in a div that was display:none. Added a check to avoid this issue. Resolves #4397
* Fixed arguments in IPlugin#before/afterDatasetUpdate description * Fixed arguments in IPlugin#before/afterDatasetDraw description
New `options.resolve` helper that determines the final value to use from an array of input values (fallback) and a given context and/or index. For now, only the bubble chart support scriptable options, see documentation for details. Add scriptable options documentation and update the bubble chart dataset properties table with their scriptable and indexable capabilities and default values. Also move point style description under the element configuration section.
Remove the special drawing for an undefined zero grid line since it causes issue when the first tick is not aligned on the scale extremity (ie only linear scales now display a special grid line for the origin). Hide scales in the filler plugin unit test fixtures to avoid future failures due to changes unrelated to the tested features.
panzarino
approved these changes
Aug 28, 2017
|
@simonbrunel my feeling is that there is still a lot of unfinished stuff with time scale, minor/ major units, gridlines, e.g. #4600 is still creating issues/confusion. Wouldn't it make sense to put effort in there and polish the time scale before releasing? |
|
People are really eager for a new release since it contains many bug fixes, delaying the new version for more weeks is not great. We don't need the grid line PR to be done for 2.7, but I agree that the minor / major concept is not (yet) ideal. I would rather disable the minor / major formatting for 2.7 (we can still plan a 2.7.1). Except that, I think the time scale is pretty stable now. If you think of other blocker bugs that needs to be addressed for 2.7, please link them in this PR. |
|
Could we get #4646 in for better looks of multi-axes charts if rebased asap? |
If `window` or `document` are `undefined`, a minimal platform implementation is used instead, which one only returns a context2d read from the given canvas/context.
|
I've sent a PR to make the major tick formatting optional and off by default #4723 |
|
I'd like to see #4554 make its way in as I think it helps document the new time series feature. I think it'd be a good one for 2.7 Also, not sure if they're blockers for 2.7, but I'd like to see nagix's pending PRs make their way in soon too even if for 2.8 |
Enforce dependencies minor versions (tilde symbol: include everything greater than a particular version in the same minor range).
Inject the GA tracking snippet for all samples, including the index page. Also update README.md badges using the shields.io service for consistency with flat-square style and cache, and add release badges to the installation documentation page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Milestone: 2.7.0
Merged PRs: 107
Checklist:
See the release process for details.