-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Violation warnings in verbose level chrome dev tools logging #4287
Labels
Milestone
Comments
I'm happy to look at a PR for this |
+1 |
asimkt
pushed a commit
to asimkt/Chart.js
that referenced
this issue
Jun 9, 2017
[BUG] Violation warnings in verbose level chrome dev tools logging
Closed
+1 |
When will this be released? It seems like quite a long time between that fix and the release.. |
+1 |
Very soon: #4706 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected Behavior
Expect Chart.js to not cause logs in dev console
Current Behavior
touchstart and touchend event listeners log verbose level [Violation] messages (see below).
Possible Solution
addEventListener can now take a map
{"passive": "true"}
see the MDN entrySteps to Reproduce (for bugs)
[Violation] Added non-passive event listener to a scroll-blocking 'touchstart' event. Consider marking event handler as 'passive' to make the page more responsive. Chart.bundle.min.js:14
Context
It's helpful to have verbose logging turned on in development because chrome will warn you when javascript execution locks up the browser. Having Chart.js warnings comingled with application logs reduces signal to noise.
Environment
The text was updated successfully, but these errors were encountered: