Added 'devicePixelRatio' option to override the window's DPR setting #4270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting this @OlduwanSteve. I like that you added some good documentation with your new config option! |
etimberg
approved these changes
May 18, 2017
simonbrunel
approved these changes
Jun 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am using chartjs for an application where the charts are baked to PDF server-side, with the eventual goal of printing them. I think this is quite common. Even for people using chartjs on the client, they may want to print the charts direct from the browser.
In either case it can be useful to force the charts to render at a higher DPR than the default window.devicePixelRatio so they look good at higher printer DPIs.
I found the existing code to deal with retina displays and I've extended it a bit to accept an override.
I could not get the docs task to run, but I think I've conformed to the style of nearby docs. Please let me know if I need to change anything.